tools/skpdiff/SkCLImageDiffer.cpp - Issue 60833002: fix multithread related crashes in skpdiff

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skpdiff/SkCLImageDiffer.cpp

Issue 60833002: fix multithread related crashes in skpdiff (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: addressing comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skpdiff/SkCLImageDiffer.cpp

diff --git a/tools/skpdiff/SkCLImageDiffer.cpp b/tools/skpdiff/SkCLImageDiffer.cpp

index d1e6958ab9f77cb1324ab545d19bc3699f87fe85..b99ef40d700f9b361462460613f883a3ee47d301 100644

--- a/tools/skpdiff/SkCLImageDiffer.cpp

+++ b/tools/skpdiff/SkCLImageDiffer.cpp

@@ -84,7 +84,7 @@ bool SkCLImageDiffer::loadKernelSource(const char source[], const char name[], c

return true;

}

-bool SkCLImageDiffer::makeImage2D(SkBitmap* bitmap, cl_mem* image) {

+bool SkCLImageDiffer::makeImage2D(SkBitmap* bitmap, cl_mem* image) const {

cl_int imageErr;

cl_image_format bitmapFormat;

switch (bitmap->config()) {