chrome/android/java/res/layout/three_button_menu_item.xml - Issue 608283004: Fix the menu alignment for the three button menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/three_button_menu_item.xml

Issue 608283004: Fix the menu alignment for the three button menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/layout/three_button_menu_item.xml

diff --git a/chrome/android/java/res/layout/three_button_menu_item.xml b/chrome/android/java/res/layout/three_button_menu_item.xml

index 5fb2d781662d77724be76e54a067c10b5605afff..2775c08ddd6d8516e071258606197e4d926a4c85 100644

--- a/chrome/android/java/res/layout/three_button_menu_item.xml

+++ b/chrome/android/java/res/layout/three_button_menu_item.xml

@@ -28,9 +28,9 @@

<ImageButton

android:id="@+id/button_three"

- android:layout_width="0dp"

+ android:layout_width="59dp"

David Trainor- moved to gerrit 2014/10/03 17:19:17 Do we need these changes? Shouldn't Java side han

Ted C 2014/10/03 18:30:01 Yeah, it turned out we only needed to clear the we

android:layout_height="match_parent"

- android:layout_weight="1"

+ android:paddingStart="11dp"

android:background="?android:attr/listChoiceBackgroundIndicator"

android:scaleType="center" />

</LinearLayout>