chrome/android/java/res/layout/three_button_menu_item.xml - Issue 608283004: Fix the menu alignment for the three button menu.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/three_button_menu_item.xml

Issue 608283004: Fix the menu alignment for the three button menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"	7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

8 android:layout_width="match_parent"	8 android:layout_width="match_parent"

9 android:layout_height="?android:attr/listPreferredItemHeightSmall"	9 android:layout_height="?android:attr/listPreferredItemHeightSmall"

10 android:layout_gravity="top\|start"	10 android:layout_gravity="top\|start"

(...skipping 10 matching lines...) Expand all Loading...
21 <ImageButton	21 <ImageButton

22 android:id="@+id/button_two"	22 android:id="@+id/button_two"

23 android:layout_width="0dp"	23 android:layout_width="0dp"

24 android:layout_height="match_parent"	24 android:layout_height="match_parent"

25 android:layout_weight="1"	25 android:layout_weight="1"

26 android:background="?android:attr/listChoiceBackgroundIndicator"	26 android:background="?android:attr/listChoiceBackgroundIndicator"

27 android:scaleType="center" />	27 android:scaleType="center" />

28	28

29 <ImageButton	29 <ImageButton

30 android:id="@+id/button_three"	30 android:id="@+id/button_three"

31 android:layout_width="0dp"	31 android:layout_width="59dp"
	David Trainor- moved to gerrit 2014/10/03 17:19:17 Do we need these changes? Shouldn't Java side han Do we need these changes? Shouldn't Java side handle it? Do we need to reset the weight? Ted C 2014/10/03 18:30:01 Yeah, it turned out we only needed to clear the we Show quoted text On 2014/10/03 17:19:17, David Trainor wrote: > Do we need these changes? Shouldn't Java side handle it? Do we need to reset > the weight? Yeah, it turned out we only needed to clear the weight on the java side.
32 android:layout_height="match_parent"	32 android:layout_height="match_parent"

33 android:layout_weight="1"	33 android:paddingStart="11dp"

34 android:background="?android:attr/listChoiceBackgroundIndicator"	34 android:background="?android:attr/listChoiceBackgroundIndicator"

35 android:scaleType="center" />	35 android:scaleType="center" />

36 </LinearLayout>	36 </LinearLayout>

OLD	NEW