chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java - Issue 608283004: Fix the menu alignment for the three button menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java

Issue 608283004: Fix the menu alignment for the three button menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java

index 2b60292ce451fd34132a30b701cd5b671b51d743..6127e13e4d0c0b710bd9f20612c0df6732665d5b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java

@@ -181,7 +181,7 @@ class AppMenuAdapter extends BaseAdapter {

setupImageButton(holder.buttons[0], item.getSubMenu().getItem(0));

setupImageButton(holder.buttons[1], item.getSubMenu().getItem(1));

if (hasMenuButton) {

- setupMenuButton(holder.buttons[3]);

+ setupMenuButton(holder.buttons[2]);

David Trainor- moved to gerrit 2014/10/03 17:19:18 Ew thanks! Nice catch.

} else {

setupImageButton(holder.buttons[2], item.getSubMenu().getItem(2));

}

« chrome/android/java/res/layout/three_button_menu_item.xml ('K') | « chrome/android/java/res/layout/three_button_menu_item.xml ('k') | no next file » | no next file with comments »