chrome/installer/util/google_update_util.cc - Issue 606473002: Remove implicit HANDLE conversions from chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_update_util.cc

Issue 606473002: Remove implicit HANDLE conversions from chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove spurious file and fix indent (+rebase) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/google_update_util.cc

diff --git a/chrome/installer/util/google_update_util.cc b/chrome/installer/util/google_update_util.cc

index 9696014ad514ab984fbdfcda1327346f8a7e5241..1b8c74d445966757499c2ccd21fabf1d4433b93e 100644

--- a/chrome/installer/util/google_update_util.cc

+++ b/chrome/installer/util/google_update_util.cc

@@ -95,7 +95,8 @@ bool LaunchProcessAndWaitWithTimeout(const base::string16& cmd_string,

if (!base::LaunchProcess(cmd_string, base::LaunchOptions(),

&process)) {

PLOG(ERROR) << "Failed to launch (" << cmd_string << ")";

- } else if (!base::WaitForExitCodeWithTimeout(process, &exit_code, timeout)) {

+ } else if (!base::WaitForExitCodeWithTimeout(process.Get(), &exit_code,

+ timeout)) {

// The GetExitCodeProcess failed or timed-out.

LOG(ERROR) <<"Command (" << cmd_string << ") is taking more than "

<< timeout.InMilliseconds() << " milliseconds to complete.";