Source/core/html/HTMLButtonElement.h - Issue 60573007: Non-activated default buttons prevent implicit form submission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLButtonElement.h

Issue 60573007: Non-activated default buttons prevent implicit form submission. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Retire dated comment on button names Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/platform/win/fast/forms/implicit-submission-expected.txt ('k') | Source/core/html/HTMLButtonElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLButtonElement.h

diff --git a/Source/core/html/HTMLButtonElement.h b/Source/core/html/HTMLButtonElement.h

index 9f33db3deda68aebd3ff8694ac987e1dac1167ee..b70cd7f90c527146628e9fd03abf614cd4fc483a 100644

--- a/Source/core/html/HTMLButtonElement.h

+++ b/Source/core/html/HTMLButtonElement.h

@@ -60,7 +60,7 @@ private:

virtual bool supportLabels() const OVERRIDE { return true; }

virtual bool isInteractiveContent() const OVERRIDE;

- virtual bool isSuccessfulSubmitButton() const;

+ virtual bool canBeSuccessfulSubmitButton() const OVERRIDE;

virtual bool isActivatedSubmit() const;

virtual void setActivatedSubmit(bool flag);

« no previous file with comments | « LayoutTests/platform/win/fast/forms/implicit-submission-expected.txt ('k') | Source/core/html/HTMLButtonElement.cpp » ('j') | no next file with comments »