Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: Source/core/html/HTMLButtonElement.h

Issue 60573007: Non-activated default buttons prevent implicit form submission. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Retire dated comment on button names Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE; 53 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE;
54 virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE; 54 virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE;
55 virtual void defaultEventHandler(Event*); 55 virtual void defaultEventHandler(Event*);
56 56
57 virtual bool appendFormData(FormDataList&, bool); 57 virtual bool appendFormData(FormDataList&, bool);
58 58
59 virtual bool isEnumeratable() const { return true; } 59 virtual bool isEnumeratable() const { return true; }
60 virtual bool supportLabels() const OVERRIDE { return true; } 60 virtual bool supportLabels() const OVERRIDE { return true; }
61 virtual bool isInteractiveContent() const OVERRIDE; 61 virtual bool isInteractiveContent() const OVERRIDE;
62 62
63 virtual bool isSuccessfulSubmitButton() const; 63 virtual bool canBeSuccessfulSubmitButton() const OVERRIDE;
64 virtual bool isActivatedSubmit() const; 64 virtual bool isActivatedSubmit() const;
65 virtual void setActivatedSubmit(bool flag); 65 virtual void setActivatedSubmit(bool flag);
66 66
67 virtual void accessKeyAction(bool sendMouseEvents); 67 virtual void accessKeyAction(bool sendMouseEvents);
68 virtual bool isURLAttribute(const Attribute&) const OVERRIDE; 68 virtual bool isURLAttribute(const Attribute&) const OVERRIDE;
69 69
70 virtual bool canStartSelection() const { return false; } 70 virtual bool canStartSelection() const { return false; }
71 71
72 virtual bool isOptionalFormControl() const { return true; } 72 virtual bool isOptionalFormControl() const { return true; }
73 virtual bool recalcWillValidate() const; 73 virtual bool recalcWillValidate() const;
74 74
75 Type m_type; 75 Type m_type;
76 bool m_isActivatedSubmit; 76 bool m_isActivatedSubmit;
77 }; 77 };
78 78
79 } // namespace 79 } // namespace
80 80
81 #endif 81 #endif
OLDNEW
« no previous file with comments | « LayoutTests/platform/win/fast/forms/implicit-submission-expected.txt ('k') | Source/core/html/HTMLButtonElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698