Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 605633002: [telemetry] Fix MSR CanMonitorPower(). (Closed)

Created:
6 years, 3 months ago by dtu
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, telemetry+watch_chromium.org, tonyg, sullivan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Fix MSR CanMonitorPower(). Ah, the dangers of dynamic typing and implicit type conversion. Typo in https://codereview.chromium.org/577893003 BUG=336556, 336558 TEST=None. TBR=thestig@chromium.org Committed: https://crrev.com/86c176b0243c51bcc5d9049de35dc778cf491f91 Cr-Commit-Position: refs/heads/master@{#296657}

Patch Set 1 #

Patch Set 2 : Unit test. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tools/telemetry/telemetry/core/platform/platform_backend_unittest.py View 1 1 chunk +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
dtu
6 years, 3 months ago (2014-09-25 04:43:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605633002/20001
6 years, 3 months ago (2014-09-25 04:44:19 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/605633002/diff/20001/tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py (right): https://codereview.chromium.org/605633002/diff/20001/tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py#newcode126 tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py:126: return True I was wondering about this today..
6 years, 3 months ago (2014-09-25 04:45:17 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6e613d68999d473ae4c67f915aaa2cb129522e63
6 years, 3 months ago (2014-09-25 05:41:44 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-25 05:42:29 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/86c176b0243c51bcc5d9049de35dc778cf491f91
Cr-Commit-Position: refs/heads/master@{#296657}

Powered by Google App Engine
This is Rietveld 408576698