tools/telemetry/telemetry/core/platform/platform_backend_unittest.py - Issue 605633002: [telemetry] Fix MSR CanMonitorPower().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/platform_backend_unittest.py

Issue 605633002: [telemetry] Fix MSR CanMonitorPower(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unit test. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py » ('j') | tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/platform_backend_unittest.py

diff --git a/tools/telemetry/telemetry/core/platform/platform_backend_unittest.py b/tools/telemetry/telemetry/core/platform/platform_backend_unittest.py

index ad18502acf5cc6413a18edac028846de7495676f..a6d37b4aed69e2c2b885ff3f0151d69306f2fed2 100644

--- a/tools/telemetry/telemetry/core/platform/platform_backend_unittest.py

+++ b/tools/telemetry/telemetry/core/platform/platform_backend_unittest.py

@@ -13,7 +13,9 @@ class PlatformBackendTest(unittest.TestCase):

def testPowerMonitoringSync(self):

# Tests that the act of monitoring power doesn't blow up.

platform = platform_module.GetHostPlatform()

- if not platform.CanMonitorPower():

+ can_monitor_power = platform.CanMonitorPower()

+ self.assertIsInstance(can_monitor_power, bool)

+ if not can_monitor_power:

logging.warning('Test not supported on this platform.')

return