tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py - Issue 605633002: [telemetry] Fix MSR CanMonitorPower().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py

Issue 605633002: [telemetry] Fix MSR CanMonitorPower(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unit test. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py

diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py b/tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py

index 624fa114f5ec69df2033edbe85f237208bed9e23..cf100174e197d2d60870851cde792e4d03d06154 100644

--- a/tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py

+++ b/tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py

@@ -123,6 +123,7 @@ class MsrPowerMonitor(power_monitor.PowerMonitor):

except OSError as e:

logging.info('Cannot monitor power: %s' % e)

return False

+ return True

Lei Zhang 2014/09/25 04:45:17 I was wondering about this today..

def _WinCanMonitorPower(self):

family, model = map(int, re.match('.+ Family ([0-9]+) Model ([0-9]+)',

« no previous file with comments | « tools/telemetry/telemetry/core/platform/platform_backend_unittest.py ('k') | no next file » | no next file with comments »