mojo/public/js/bindings/codec_unittests.js - Issue 605443002: The default value for NullableString should be null (was "")

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/js/bindings/codec_unittests.js

Issue 605443002: The default value for NullableString should be null (was "") (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/js/bindings/codec_unittests.js

diff --git a/mojo/public/js/bindings/codec_unittests.js b/mojo/public/js/bindings/codec_unittests.js

index 80f1402eef2ac0c7df9f346f1f80ba17fe7fddbe..0276db21bae8c00cfa9c745b776fd5f28d691f67 100644

--- a/mojo/public/js/bindings/codec_unittests.js

+++ b/mojo/public/js/bindings/codec_unittests.js

@@ -188,6 +188,7 @@ define([

expect(result).toEqual(expectedResult);

}

encodeDecode(codec.String, "banana", "banana", 24);

+ encodeDecode(codec.NullableString, null, null, 8);

encodeDecode(codec.Int8, -1, -1);

encodeDecode(codec.Int8, 0xff, -1);

encodeDecode(codec.Int16, -1, -1);

« no previous file with comments | « no previous file | mojo/public/js/bindings/struct_unittests.js » ('j') | mojo/public/tools/bindings/generators/mojom_js_generator.py » ('J')