Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1396)

Unified Diff: mojo/public/js/bindings/struct_unittests.js

Issue 605443002: The default value for NullableString should be null (was "") (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/js/bindings/struct_unittests.js
diff --git a/mojo/public/js/bindings/struct_unittests.js b/mojo/public/js/bindings/struct_unittests.js
index d4a568ccf41f8bde7995025345535ed3d791a2fa..aba01baab11b43aa9c63fea033f332ab9914da50 100644
--- a/mojo/public/js/bindings/struct_unittests.js
+++ b/mojo/public/js/bindings/struct_unittests.js
@@ -26,8 +26,7 @@ define([
expect(new testStructs.RectPair({second: r}).first).toBeNull();
var nr = new testStructs.NamedRegion();
- // TODO(hansmuller): nr.name should be null, see crbug.com/417039.
- expect(nr.name).toBe("");
+ expect(nr.name).toBeNull();
expect(nr.rects).toBeNull();
expect(nr).toEqual(new testStructs.NamedRegion({}));

Powered by Google App Engine
This is Rietveld 408576698