The default value for NullableString should be null (was "")

mojo/public/tools/bindings/generators/mojom_js_generator.py

Index: mojo/public/tools/bindings/generators/mojom_js_generator.py
diff --git a/mojo/public/tools/bindings/generators/mojom_js_generator.py b/mojo/public/tools/bindings/generators/mojom_js_generator.py
index 18209977d1438b5e6a05460993f453e6291a385e..4e77714f11d825e4fdfdc8677766c01603d99177 100644
--- a/mojo/public/tools/bindings/generators/mojom_js_generator.py
+++ b/mojo/public/tools/bindings/generators/mojom_js_generator.py
@@ -32,7 +32,7 @@ _kind_to_javascript_default_value = {
   mojom.UINT64:                "0",
   mojom.DOUBLE:                "0",
   mojom.STRING:                '""',

[yzshen1, 2014/09/24 19:41:56]

I think if a default value is unspecified, this should be initialized to null,
too. (according to the current design proposal.)

Nullable or not is purely for validation purpose. It has nothing to do with
initialization. So a string/struct/array/handle is non-nullable doesn't mean it
is initialized to non-null, intead it means that the user needs to set a value
for it before sending it on a pipe.

What do you think? Thanks!

[hansmuller, 2014/09/24 22:12:07]

OK, I agree with this. Both kinds of String fields are now null by default.

-  mojom.NULLABLE_STRING:       '""'
+  mojom.NULLABLE_STRING:       "null"
 }