Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 604833005: gpu: Remove release-after-use workaround. (Closed)

Created:
6 years, 2 months ago by reveman
Modified:
6 years, 2 months ago
Reviewers:
boliu, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-in-process-support-for-images
Project:
chromium
Visibility:
Public.

Description

gpu: Remove release-after-use workaround. This is no longer used after removing in-process GPU service support for CHROMIUM_image. BUG=418553 Committed: https://crrev.com/c0c002bdedfccdc6426e1e1cf3a04ebb639a2d4f Cr-Commit-Position: refs/heads/master@{#297276}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : update bug list version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -57 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 2 chunks +1 line, -17 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_image.h View 2 chunks +2 lines, -6 lines 0 comments Download
D ui/gl/gl_image.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
reveman
6 years, 2 months ago (2014-09-29 18:59:07 UTC) #2
boliu
lg2m https://codereview.chromium.org/604833005/diff/20001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/604833005/diff/20001/gpu/config/gpu_driver_bug_list_json.cc#newcode22 gpu/config/gpu_driver_bug_list_json.cc:22: "version": "7.3", I think you are supposed to ...
6 years, 2 months ago (2014-09-29 19:58:40 UTC) #3
reveman
https://codereview.chromium.org/604833005/diff/20001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/604833005/diff/20001/gpu/config/gpu_driver_bug_list_json.cc#newcode22 gpu/config/gpu_driver_bug_list_json.cc:22: "version": "7.3", On 2014/09/29 19:58:40, boliu wrote: > I ...
6 years, 2 months ago (2014-09-29 20:01:43 UTC) #4
piman
lgtm
6 years, 2 months ago (2014-09-29 20:33:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604833005/40001
6 years, 2 months ago (2014-09-29 20:40:32 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as b2f27de6cb0fbf18c52c295208b325963e54d660
6 years, 2 months ago (2014-09-29 21:46:32 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 21:49:35 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c0c002bdedfccdc6426e1e1cf3a04ebb639a2d4f
Cr-Commit-Position: refs/heads/master@{#297276}

Powered by Google App Engine
This is Rietveld 408576698