Use ExceptionState when converting string arguments to promise methods

Use ExceptionState when converting string arguments to promise methods

A method whose return type is Promise should never throw an exception
directly, instead it should return a rejected promise holding the
exception that would have been thrown.

Because of this, string arguments in such methods were converted using a
special macro that extracted the exception from the v8::TryCatch local.

Since we want to get rid of that v8::TryCatch local, and also have a
V8StringResource::prepare() overload that reports exceptions via an
ExceptionState argument, use that for the method-returning-Promise case.

BUG=413257
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182687

[Jens Widell, 2014-09-25 13:47:49]

jl@opera.com changed reviewers:
+ haraken@chromium.org, yhirano@chromium.org

[Jens Widell, 2014-09-25 13:47:50]

PTAL

FYI, this CL removes the final argument conversion v8::TryCatch from the
generated bindings code.

[Jens Widell, 2014-09-25 13:51:15]

https://codereview.chromium.org/604833002/diff/1/Source/bindings/core/v8/V8Bi...
File Source/bindings/core/v8/V8BindingMacros.h (left):

https://codereview.chromium.org/604833002/diff/1/Source/bindings/core/v8/V8Bi...
Source/bindings/core/v8/V8BindingMacros.h:148: #define
TOSTRING_VOID_PROMISE(type, var, value, info)           \
This macro was never used, BTW. The corresponding TONATIVE_VOID() and
TOSTRING_VOID() macros are used in attribute setters, but the "_PROMISE" in the
name of these macros means "method that returns Promise," so they can never be
relevant for attributes.

[haraken, 2014-09-25 15:16:00]

LGTM

[Jens Widell, 2014-09-25 15:16:48]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-09-25 15:17:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/604833002/1

[commit-bot: I haz the power, 2014-09-25 16:00:37]

Committed patchset #1 (id:1) as 182687

[yhirano, 2014-09-26 00:53:30]

lgtm