Use ExceptionState when converting string arguments to promise methods

Source/bindings/core/v8/V8BindingMacros.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 117 matching lines @@
 #define TOSTRING_VOID_INTERNAL(var, value) \
     var = (value);                         \
     if (UNLIKELY(!var.prepare()))          \
         return;
 
 #define TOSTRING_DEFAULT(type, var, value, retVal) \
     type var(value);                               \
     if (UNLIKELY(!var.prepare()))                  \
         return retVal;
 
-// We need to cancel the exception propergation when we return a rejected
+// We need to cancel the exception propagation when we return a rejected
 // Promise.
-#define TOSTRING_VOID_PROMISE_INTERNAL(var, value, info)                                           \
-    var = (value);                                                                                 \
-    if (UNLIKELY(!var.prepare()))  {                                                               \
-        info.GetReturnValue().Set(ScriptPromise::rejectRaw(info.GetIsolate(), block.Exception())); \
-        block.Reset();                                                                             \
-        return;                                                                                    \
-    }
-
-#define TOSTRING_VOID_PROMISE(type, var, value, info)           \

[Jens Widell, 2014/09/25 13:51:14]

This macro was never used, BTW. The corresponding TONATIVE_VOID() and
TOSTRING_VOID() macros are used in attribute setters, but the "_PROMISE" in the
name of these macros means "method that returns Promise," so they can never be
relevant for attributes.

-    type var;                                                   \
-    {                                                           \
-        v8::TryCatch block;                                     \
-        TOSTRING_VOID_PROMISE_INTERNAL(type, var, value, info); \
+#define TOSTRING_VOID_EXCEPTIONSTATE_PROMISE_INTERNAL(var, value, exceptionState, info, scriptState) \
+    var = (value);                                                                                   \
+    if (UNLIKELY(!var.prepare(exceptionState)))  {                                                   \
+        v8SetReturnValue(info, exceptionState.reject(scriptState).v8Value());                        \
+        return;                                                                                      \
     }
 
 } // namespace blink
 
 #endif // V8BindingMacros_h