Use ExceptionState when converting string arguments to promise methods

Source/bindings/scripts/v8_types.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 552 matching lines @@
     # FIXME: Support union type.
     if idl_type.is_union_type:
         return ''
 
     this_cpp_type = idl_type.cpp_type_args(extended_attributes=extended_attributes, raw_type=True)
 
     idl_type = idl_type.preprocessed_type
     cpp_value = v8_value_to_cpp_value(idl_type, extended_attributes, v8_value, index, isolate)
     args = [variable_name, cpp_value]
     if idl_type.base_type == 'DOMString':
-        macro = 'TOSTRING_DEFAULT' if used_in_private_script else 'TOSTRING_VOID'
+        if return_promise:
+            macro = 'TOSTRING_VOID_EXCEPTIONSTATE'
+        else:
+            macro = 'TOSTRING_DEFAULT' if used_in_private_script else 'TOSTRING_VOID'
     elif idl_type.v8_conversion_needs_exception_state:
         macro = 'TONATIVE_DEFAULT_EXCEPTIONSTATE' if used_in_private_script else 'TONATIVE_VOID_EXCEPTIONSTATE'
-        args.append('exceptionState')
     elif idl_type.v8_conversion_is_trivial:
         assignment = '%s = %s' % (variable_name, cpp_value)
         if declare_variable:
             return '%s %s' % (this_cpp_type, assignment)
         return assignment
     else:
         macro = 'TONATIVE_DEFAULT' if used_in_private_script else 'TONATIVE_VOID'
 
+    if macro.endswith('_EXCEPTIONSTATE'):
+        args.append('exceptionState')
+
     if used_in_private_script:
         args.append('false')
 
     # Macros come in several variants, to minimize expensive creation of
     # v8::TryCatch.
     suffix = ''
 
     if return_promise:
         suffix += '_PROMISE'
         args.append('info')
-        if macro == 'TONATIVE_VOID_EXCEPTIONSTATE':
+        if macro.endswith('_EXCEPTIONSTATE'):
             args.append('ScriptState::current(%s)' % isolate)
 
     if declare_variable:
         args.insert(0, this_cpp_type)
     else:
         suffix += '_INTERNAL'
 
     return '%s(%s)' % (macro + suffix, ', '.join(args))
 
 IdlTypeBase.v8_value_to_local_cpp_value = v8_value_to_local_cpp_value
@@ skipping 239 matching lines @@
 
 
 def is_explicit_nullable(idl_type):
     # Nullable type that isn't implicit nullable (see above.) For such types,
     # we use Nullable<T> or similar explicit ways to represent a null value.
     return idl_type.is_nullable and not idl_type.is_implicit_nullable
 
 IdlTypeBase.is_implicit_nullable = property(is_implicit_nullable)
 IdlUnionType.is_implicit_nullable = False
 IdlTypeBase.is_explicit_nullable = property(is_explicit_nullable)