Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 603383003: Declaring the weak_ptr_factory in proper order. (Closed)

Created:
6 years, 2 months ago by Anand Ratn (left samsung)
Modified:
6 years, 2 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Declaring the weak_ptr_factory in proper order. Cleaning up weak_ptr_factory destruction order in "src/chrome/browser/ui" module. WeakPtrFactory should remain the last member so it'll be destroyed and invalidate its weak pointers before any other members are destroyed. BUG=303818 Committed: https://crrev.com/fdc1f3db2859d81d9f4e673b25cc2ff1f73ad2ed Cr-Commit-Position: refs/heads/master@{#296898}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Anand Ratn (left samsung)
isherman@chromium.org: Please review changes in src/chrome/browser/ui/autofill/ module
6 years, 2 months ago (2014-09-26 05:54:22 UTC) #2
Ilya Sherman
LGTM, thanks.
6 years, 2 months ago (2014-09-26 05:56:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603383003/20001
6 years, 2 months ago (2014-09-26 05:56:40 UTC) #5
Anand Ratn (left samsung)
On 2014/09/26 05:56:15, Ilya Sherman wrote: > LGTM, thanks. Thanks for the review Ilya.
6 years, 2 months ago (2014-09-26 05:57:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0d1fe11f931461040b527ddb2c75f8730e1d9cd7
6 years, 2 months ago (2014-09-26 06:50:06 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 06:50:45 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fdc1f3db2859d81d9f4e673b25cc2ff1f73ad2ed
Cr-Commit-Position: refs/heads/master@{#296898}

Powered by Google App Engine
This is Rietveld 408576698