Declaring the weak_ptr_factory in proper order.

chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 113 matching lines @@
       : AutofillDialogControllerImpl(contents,
                                      form_data,
                                      form_data.origin,
                                      base::Bind(&MockCallback)),
         metric_logger_(metric_logger),
         mock_wallet_client_(
             Profile::FromBrowserContext(contents->GetBrowserContext())->
                 GetRequestContext(), this, form_data.origin),
         message_loop_runner_(runner),
         use_validation_(false),
-        weak_ptr_factory_(this),
-        sign_in_user_index_(0U) {
+        sign_in_user_index_(0U),
+        weak_ptr_factory_(this) {
     test_manager_.Init(
         NULL,
         Profile::FromBrowserContext(contents->GetBrowserContext())->GetPrefs(),
         false);
   }
 
   virtual ~TestAutofillDialogController() {}
 
   virtual GURL SignInUrl() const OVERRIDE {
     return GURL(chrome::kChromeUIVersionURL);
@@ skipping 108 matching lines @@
   TestPersonalDataManager test_manager_;
   testing::NiceMock<MockAddressValidator> mock_validator_;
   testing::NiceMock<wallet::MockWalletClient> mock_wallet_client_;
   scoped_refptr<content::MessageLoopRunner> message_loop_runner_;
   bool use_validation_;
 
   // A list of notifications to show in the notification area of the dialog.
   // This is used to control what |CurrentNotifications()| returns for testing.
   std::vector<DialogNotification> notifications_;
 
+  // The user index that is assigned in IsSignInContinueUrl().
+  size_t sign_in_user_index_;
+
   // Allows generation of WeakPtrs, so controller liveness can be tested.
   base::WeakPtrFactory<TestAutofillDialogController> weak_ptr_factory_;
 
-  // The user index that is assigned in IsSignInContinueUrl().
-  size_t sign_in_user_index_;
-
   DISALLOW_COPY_AND_ASSIGN(TestAutofillDialogController);
 };
 
 // This is a copy of ui_test_utils::UrlLoadObserver, except it observes
 // NAV_ENTRY_COMMITTED instead of LOAD_STOP. This is to match the notification
 // that AutofillDialogControllerImpl observes. Since NAV_ENTRY_COMMITTED comes
 // before LOAD_STOP, and the controller deletes the web contents after receiving
 // the former, we will sometimes fail to observe a LOAD_STOP.
 // TODO(estade): Should the controller observe LOAD_STOP instead?
 class NavEntryCommittedObserver : public content::WindowedNotificationObserver {
@@ skipping 1486 matching lines @@
       "<input autocomplete='transaction-currency' value='USD'>"
       "<input autocomplete='cc-csc'>");
   AutofillDialogControllerImpl* controller = SetUpHtmlAndInvoke(html);
   ASSERT_TRUE(controller);
 
   EXPECT_EQ(ASCIIToUTF16("24"), controller->transaction_amount_);
   EXPECT_EQ(ASCIIToUTF16("USD"), controller->transaction_currency_);
 }
 
 }  // namespace autofill