Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc

Issue 603383003: Declaring the weak_ptr_factory in proper order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
index 4dba69f14b8864dfbf903dbc064fbe61a0c84cd7..f4b074f7e03212ccab748382eddc75b4f55a7024 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
@@ -131,8 +131,8 @@ class TestAutofillDialogController : public AutofillDialogControllerImpl {
GetRequestContext(), this, form_data.origin),
message_loop_runner_(runner),
use_validation_(false),
- weak_ptr_factory_(this),
- sign_in_user_index_(0U) {
+ sign_in_user_index_(0U),
+ weak_ptr_factory_(this) {
test_manager_.Init(
NULL,
Profile::FromBrowserContext(contents->GetBrowserContext())->GetPrefs(),
@@ -261,12 +261,12 @@ class TestAutofillDialogController : public AutofillDialogControllerImpl {
// This is used to control what |CurrentNotifications()| returns for testing.
std::vector<DialogNotification> notifications_;
- // Allows generation of WeakPtrs, so controller liveness can be tested.
- base::WeakPtrFactory<TestAutofillDialogController> weak_ptr_factory_;
-
// The user index that is assigned in IsSignInContinueUrl().
size_t sign_in_user_index_;
+ // Allows generation of WeakPtrs, so controller liveness can be tested.
+ base::WeakPtrFactory<TestAutofillDialogController> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(TestAutofillDialogController);
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698