Move RenderSVGImage's paint code to SVGImagePainter

Move RenderSVGImage's paint code to SVGImagePainter

This patch moves RenderSVGImage's paint functions to SVGImagePainter.
This is a straight code refactor with no changes other than exposing a
few functions on RenderSVGImage.

The one hairy part of this patch is the buffered rendering support
we have in RenderSVGImage. This has been moved to a static function
on SVGImagePainter and all callers have been updated.

BUG=412088
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182704

[pdr., 2014-09-25 05:01:16]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[fs, 2014-09-25 11:09:59]

fs@opera.com changed reviewers:
+ fs@opera.com

[fs, 2014-09-25 11:09:59]

lgtm

[pdr., 2014-09-25 18:05:48]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-09-25 18:06:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/603053002/1

[commit-bot: I haz the power, 2014-09-25 18:55:10]

Committed patchset #1 (id:1) as 182704

[f(malita), 2014-10-24 20:11:52]

fmalita@chromium.org changed reviewers:
+ fmalita@chromium.org

[f(malita), 2014-10-24 20:11:53]

https://codereview.chromium.org/603053002/diff/1/Source/core/rendering/svg/Re...
File Source/core/rendering/svg/RenderSVGImage.h (right):

https://codereview.chromium.org/603053002/diff/1/Source/core/rendering/svg/Re...
Source/core/rendering/svg/RenderSVGImage.h:47: OwnPtr<ImageBuffer>&
bufferedForeground() { return m_bufferedForeground; }
Belated comment: encapsulation-- :(

Do we have a general strategy for passing private renderer info to painters?

Some options

1) make all needed info a (packaged?) param to paint() - this will not fly if we
want paint() to follow a uniform interface (which I believe is desirable)

2) pass all info to the painter constructor

3) befriend painters <-> renderers

I'm thinking #2 is preferable, but honestly I would take any of them over
exposing renderer guts publicly :)

[chrishtr, 2014-10-27 03:38:35]

On 2014/10/24 at 20:11:53, fmalita wrote:
>
https://codereview.chromium.org/603053002/diff/1/Source/core/rendering/svg/Re...
> File Source/core/rendering/svg/RenderSVGImage.h (right):
> 
>
https://codereview.chromium.org/603053002/diff/1/Source/core/rendering/svg/Re...
> Source/core/rendering/svg/RenderSVGImage.h:47: OwnPtr<ImageBuffer>&
bufferedForeground() { return m_bufferedForeground; }
> Belated comment: encapsulation-- :(
> 
> Do we have a general strategy for passing private renderer info to painters?
> 
> Some options
> 
> 1) make all needed info a (packaged?) param to paint() - this will not fly if
we want paint() to follow a uniform interface (which I believe is desirable)
> 
> 2) pass all info to the painter constructor
> 
> 3) befriend painters <-> renderers
> 
> I'm thinking #2 is preferable, but honestly I would take any of them over
exposing renderer guts publicly :)

The plan is to expose the things that are need as public, and then package them
later once all painters are implemented. Making them public in the meantime is
not amazing, but we are prioritizing speed & simplicity of the refactoring over
that.

(Friend classes in particular are not a good solution since they expose
non-public info.)