Move RenderSVGImage's paint code to SVGImagePainter

Source/core/rendering/svg/RenderSVGImage.h

 /*
  * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org>
  * Copyright (C) 2006, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Rob Buis <buis@kde.org>
  * Copyright (C) 2009 Google, Inc.
  * Copyright (C) 2010 Patrick Gansterer <paroga@paroga.com>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 25 matching lines @@
     explicit RenderSVGImage(SVGImageElement*);
     virtual ~RenderSVGImage();
     virtual void destroy() OVERRIDE;
 
     bool updateImageViewport();
     virtual void setNeedsBoundariesUpdate() OVERRIDE { m_needsBoundariesUpdate = true; }
     virtual void setNeedsTransformUpdate() OVERRIDE { m_needsTransformUpdate = true; }
 
     RenderImageResource* imageResource() { return m_imageResource.get(); }
 
-    // Note: Assumes the PaintInfo context has had all local transforms applied.
-    void paintForeground(PaintInfo&);
+    virtual const AffineTransform& localToParentTransform() const OVERRIDE { return m_localTransform; }
+    OwnPtr<ImageBuffer>& bufferedForeground() { return m_bufferedForeground; }

[f(malita), 2014/10/24 20:11:53]

Belated comment: encapsulation-- :(

Do we have a general strategy for passing private renderer info to painters?

Some options

1) make all needed info a (packaged?) param to paint() - this will not fly if we
want paint() to follow a uniform interface (which I believe is desirable)

2) pass all info to the painter constructor

3) befriend painters <-> renderers

I'm thinking #2 is preferable, but honestly I would take any of them over
exposing renderer guts publicly :)

+
+    virtual FloatRect paintInvalidationRectInLocalCoordinates() const OVERRIDE { return m_paintInvalidationBoundingBox; }
+    virtual FloatRect objectBoundingBox() const OVERRIDE { return m_objectBoundingBox; }
 
 private:
     virtual const char* renderName() const OVERRIDE { return "RenderSVGImage"; }
     virtual bool isSVGImage() const OVERRIDE { return true; }
 
-    virtual const AffineTransform& localToParentTransform() const OVERRIDE { return m_localTransform; }
-
-    virtual FloatRect objectBoundingBox() const OVERRIDE { return m_objectBoundingBox; }
     virtual FloatRect strokeBoundingBox() const OVERRIDE { return m_objectBoundingBox; }
-    virtual FloatRect paintInvalidationRectInLocalCoordinates() const OVERRIDE { return m_paintInvalidationBoundingBox; }
 
     virtual void addFocusRingRects(Vector<LayoutRect>&, const LayoutPoint& additionalOffset, const RenderLayerModelObject* paintContainer) const OVERRIDE;
 
     virtual void imageChanged(WrappedImagePtr, const IntRect* = 0) OVERRIDE;
 
     virtual void layout() OVERRIDE;
     virtual void paint(PaintInfo&, const LayoutPoint&) OVERRIDE;
 
     bool forceNonUniformScaling(SVGImageElement*) const;
     void invalidateBufferedForeground();
@@ skipping 10 matching lines @@
     OwnPtr<RenderImageResource> m_imageResource;
 
     OwnPtr<ImageBuffer> m_bufferedForeground;
 };
 
 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderSVGImage, isSVGImage());
 
 } // namespace blink
 
 #endif // RenderSVGImage_h