Fixed a mismatch of UMA GCM metric name between files

Fixed a mismatch of UMA GCM metric name between the code and the histograms.xml file.

BUG=416561
Committed: https://crrev.com/d505f246c6c634d8725a2fd7e86987a14a111ef9
Cr-Commit-Position: refs/heads/master@{#296777}

[juyik, 2014-09-24 22:55:09]

juyik@chromium.org changed reviewers:
+ fgorski@chromium.org

[fgorski, 2014-09-25 03:37:35]

lgtm, but please address my comment.

https://codereview.chromium.org/603023002/diff/1/components/gcm_driver/gcm_cl...
File components/gcm_driver/gcm_client_impl.cc (right):

https://codereview.chromium.org/603023002/diff/1/components/gcm_driver/gcm_cl...
components/gcm_driver/gcm_client_impl.cc:174: ttl_category =
TTL_MORE_THAN_ONE_WEEK;
Now that kMaximumTTL is less than a day, the last if does not make sense. We
could either drop the last 2 ifs, and go directly to TTL_MAXIMUM, or change the
if with kMaximumTTL to 4 weeks, the way it used to be. I opt for the first one.
(UMA will show the 2 categories to always be empty is my guess.)

[juyik, 2014-09-25 19:43:59]

On 2014/09/25 03:37:35, fgorski wrote:
> lgtm, but please address my comment.
> 
>
https://codereview.chromium.org/603023002/diff/1/components/gcm_driver/gcm_cl...
> File components/gcm_driver/gcm_client_impl.cc (right):
> 
>
https://codereview.chromium.org/603023002/diff/1/components/gcm_driver/gcm_cl...
> components/gcm_driver/gcm_client_impl.cc:174: ttl_category =
> TTL_MORE_THAN_ONE_WEEK;
> Now that kMaximumTTL is less than a day, the last if does not make sense. We
> could either drop the last 2 ifs, and go directly to TTL_MAXIMUM, or change
the
> if with kMaximumTTL to 4 weeks, the way it used to be. I opt for the first
one.
> (UMA will show the 2 categories to always be empty is my guess.)

Done

[juyik, 2014-09-25 19:44:25]

The CQ bit was checked by juyik@chromium.org

[juyik, 2014-09-25 19:44:44]

https://codereview.chromium.org/603023002/diff/1/components/gcm_driver/gcm_cl...
File components/gcm_driver/gcm_client_impl.cc (right):

https://codereview.chromium.org/603023002/diff/1/components/gcm_driver/gcm_cl...
components/gcm_driver/gcm_client_impl.cc:174: ttl_category =
TTL_MORE_THAN_ONE_WEEK;
On 2014/09/25 03:37:34, fgorski wrote:
> Now that kMaximumTTL is less than a day, the last if does not make sense. We
> could either drop the last 2 ifs, and go directly to TTL_MAXIMUM, or change
the
> if with kMaximumTTL to 4 weeks, the way it used to be. I opt for the first
one.
> (UMA will show the 2 categories to always be empty is my guess.)

Done.

[commit-bot: I haz the power, 2014-09-25 19:45:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/603023002/20001

[commit-bot: I haz the power, 2014-09-25 20:08:06]

Committed patchset #2 (id:20001) as addcbafd1bc1b9d121f17bed49e9033a54fdc714

[commit-bot: I haz the power, 2014-09-25 20:08:45]

Patchset 2 (id:??) landed as
https://crrev.com/d505f246c6c634d8725a2fd7e86987a14a111ef9
Cr-Commit-Position: refs/heads/master@{#296777}