Fixed a mismatch of UMA GCM metric name between files

components/gcm_driver/gcm_client_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/gcm_driver/gcm_client_impl.h"
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 153 matching lines @@
     ttl_category = TTL_ZERO;
   else if (message.time_to_live <= 60 )
     ttl_category = TTL_LESS_THAN_OR_EQUAL_TO_ONE_MINUTE;
   else if (message.time_to_live <= 60 * 60)
     ttl_category = TTL_LESS_THAN_OR_EQUAL_TO_ONE_HOUR;
   else if (message.time_to_live <= 24 * 60 * 60)
     ttl_category = TTL_LESS_THAN_OR_EQUAL_TO_ONE_DAY;
   else if (message.time_to_live <= 7 * 24 * 60 * 60)
     ttl_category = TTL_LESS_THAN_OR_EQUAL_TO_ONE_WEEK;
   else if (message.time_to_live < gcm::GCMClient::OutgoingMessage::kMaximumTTL)
     ttl_category = TTL_MORE_THAN_ONE_WEEK;

[fgorski, 2014/09/25 03:37:34]

Now that kMaximumTTL is less than a day, the last if does not make sense. We
could either drop the last 2 ifs, and go directly to TTL_MAXIMUM, or change the
if with kMaximumTTL to 4 weeks, the way it used to be. I opt for the first one.
(UMA will show the 2 categories to always be empty is my guess.)

[juyik, 2014/09/25 19:44:44]

Done.

   else
     ttl_category = TTL_MAXIMUM;
 
-  UMA_HISTOGRAM_ENUMERATION("GCM.GCMOutgoingMessageTTLCategory",
+  UMA_HISTOGRAM_ENUMERATION("GCM.OutgoingMessageTTL",
                             ttl_category,
                             TTL_CATEGORY_COUNT);
 }
 
 }  // namespace
 
 GCMInternalsBuilder::GCMInternalsBuilder() {}
 GCMInternalsBuilder::~GCMInternalsBuilder() {}
 
 scoped_ptr<base::Clock> GCMInternalsBuilder::BuildClock() {
@@ skipping 764 matching lines @@
 
   recorder_.RecordIncomingSendError(
       data_message_stanza.category(),
       data_message_stanza.to(),
       data_message_stanza.id());
   delegate_->OnMessageSendError(data_message_stanza.category(),
                                 send_error_details);
 }
 
 }  // namespace gcm