Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: components/gcm_driver/gcm_client_impl.cc

Issue 603023002: Fixed a mismatch of UMA GCM metric name between files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Filip's comment. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_client_impl.cc
diff --git a/components/gcm_driver/gcm_client_impl.cc b/components/gcm_driver/gcm_client_impl.cc
index d1fc7a08851675aba29f11d23e8b5f872664d0b5..fbe6140976fe0fd27bd2025115219e91cd6b0448 100644
--- a/components/gcm_driver/gcm_client_impl.cc
+++ b/components/gcm_driver/gcm_client_impl.cc
@@ -168,14 +168,10 @@ void RecordOutgoingMessageToUMA(
ttl_category = TTL_LESS_THAN_OR_EQUAL_TO_ONE_HOUR;
else if (message.time_to_live <= 24 * 60 * 60)
ttl_category = TTL_LESS_THAN_OR_EQUAL_TO_ONE_DAY;
- else if (message.time_to_live <= 7 * 24 * 60 * 60)
- ttl_category = TTL_LESS_THAN_OR_EQUAL_TO_ONE_WEEK;
- else if (message.time_to_live < gcm::GCMClient::OutgoingMessage::kMaximumTTL)
- ttl_category = TTL_MORE_THAN_ONE_WEEK;
else
ttl_category = TTL_MAXIMUM;
- UMA_HISTOGRAM_ENUMERATION("GCM.GCMOutgoingMessageTTLCategory",
+ UMA_HISTOGRAM_ENUMERATION("GCM.OutgoingMessageTTL",
ttl_category,
TTL_CATEGORY_COUNT);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698