Issue 602973004: [Android] Make SetJavaAsserts return True if a restart is required.

Issue 602973004: [Android] Make SetJavaAsserts return True if a restart is required. (Closed)

Created:
6 years, 2 months ago by jbudorick

Modified:
6 years, 2 months ago

Reviewers:
klundberg, craigdh

CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

[Android] Make SetJavaAsserts return True if a restart is required. BUG=417705 Committed: https://crrev.com/ecd91a8874584f5b3768514aece927a06f1b65de Cr-Commit-Position: refs/heads/master@{#296736}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	build/android/pylib/device/device_utils.py	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	build/android/pylib/device/device_utils_test.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 13 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602973004/1

6 years, 2 months ago (2014-09-25 15:56:12 UTC) #5

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

6 years, 2 months ago (2014-09-25 15:56:13 UTC) #7

craigdh

lgtm. Huh, seems odd that Karin's permissions haven't kicked in yet.

6 years, 2 months ago (2014-09-25 16:23:32 UTC) #8

jbudorick

On 2014/09/25 16:23:32, craigdh wrote: > lgtm. Huh, seems odd that Karin's permissions haven't kicked ...

6 years, 2 months ago (2014-09-25 16:24:11 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602973004/1

6 years, 2 months ago (2014-09-25 16:25:16 UTC) #11

commit-bot: I haz the power

Committed patchset #1 (id:1) as 5f2f7cfc4a44ee5c4af3d89fb0aa8206a7348886

6 years, 2 months ago (2014-09-25 17:39:11 UTC) #12

commit-bot: I haz the power

6 years, 2 months ago (2014-09-25 17:39:57 UTC) #13

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ecd91a8874584f5b3768514aece927a06f1b65de
Cr-Commit-Position: refs/heads/master@{#296736}