build/android/pylib/device/device_utils_test.py - Issue 602973004: [Android] Make SetJavaAsserts return True if a restart is required.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/device/device_utils_test.py

Issue 602973004: [Android] Make SetJavaAsserts return True if a restart is required. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/device/device_utils_test.py

diff --git a/build/android/pylib/device/device_utils_test.py b/build/android/pylib/device/device_utils_test.py

index 1796fbe2186a6cd83edfa4806dddb7c93f723682..42dc5b2ccbcea5f9790cfa715e64a0ee576003bd 100755

--- a/build/android/pylib/device/device_utils_test.py

+++ b/build/android/pylib/device/device_utils_test.py

@@ -1312,7 +1312,7 @@ class DeviceUtilsSetJavaAssertsTest(DeviceUtilsOldImplTest):

('adb -s 0123456789abcdef shell '

'setprop dalvik.vm.enableassertions "all"',

'')]):

- self.device.SetJavaAsserts(True)

+ self.assertTrue(self.device.SetJavaAsserts(True))

def testSetJavaAsserts_disable(self):

mock_file = self.mockNamedTemporary(

@@ -1336,7 +1336,7 @@ class DeviceUtilsSetJavaAssertsTest(DeviceUtilsOldImplTest):

('adb -s 0123456789abcdef shell '

'setprop dalvik.vm.enableassertions ""',

'')]):

- self.device.SetJavaAsserts(False)

+ self.assertTrue(self.device.SetJavaAsserts(False))

def testSetJavaAsserts_alreadyEnabled(self):

mock_file = self.mockNamedTemporary(

« no previous file with comments | « build/android/pylib/device/device_utils.py ('k') | no next file » | no next file with comments »