build/android/pylib/device/device_utils.py - Issue 602973004: [Android] Make SetJavaAsserts return True if a restart is required.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/device/device_utils.py

Issue 602973004: [Android] Make SetJavaAsserts return True if a restart is required. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/device/device_utils.py

diff --git a/build/android/pylib/device/device_utils.py b/build/android/pylib/device/device_utils.py

index 0e49f568f648806948cdbed564a05cbc719be412..fccdd619d02322e10763424405f78aa477e82c6a 100644

--- a/build/android/pylib/device/device_utils.py

+++ b/build/android/pylib/device/device_utils.py

@@ -689,10 +689,14 @@ class DeviceUtils(object):

timeout: timeout in seconds

retries: number of retries

+ Returns:

+ True if the device-side property changed and a restart is required as a

+ result, False otherwise.

Raises:

CommandTimeoutError on timeout.

"""

- self.old_interface.SetJavaAssertsEnabled(enabled)

+ return self.old_interface.SetJavaAssertsEnabled(enabled)

@decorators.WithTimeoutAndRetriesFromInstance()

def GetProp(self, property_name, timeout=None, retries=None):

« no previous file with comments | « no previous file | build/android/pylib/device/device_utils_test.py » ('j') | no next file with comments »