Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Unified Diff: components/signin/core/browser/about_signin_internals.cc

Issue 602773002: Handle multiple signin_internal_uis by using a linked_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/about_signin_internals.cc
diff --git a/components/signin/core/browser/about_signin_internals.cc b/components/signin/core/browser/about_signin_internals.cc
index 86db713f65c99ddc0ba2b68d831a660b64e19033..e1982aff0c36f1476d2447ba87eb438823c41f7c 100644
--- a/components/signin/core/browser/about_signin_internals.cc
+++ b/components/signin/core/browser/about_signin_internals.cc
@@ -324,7 +324,7 @@ void AboutSigninInternals::OnListAccountsFailure(
void AboutSigninInternals::OnListAccountsComplete(
std::vector<std::pair<std::string, bool> >& gaia_accounts) {
- scoped_ptr<base::DictionaryValue> signin_status(new base::DictionaryValue());
+ linked_ptr<base::DictionaryValue> signin_status(new base::DictionaryValue());
Roger Tawa OOO till Jul 10th 2014/09/25 01:14:05 Could declare this on the stack: base::Diction
Mike Lerman 2014/09/25 17:28:34 Done.
base::ListValue* cookie_info = new base::ListValue();
signin_status->Set("cookie_info", cookie_info);
@@ -340,7 +340,7 @@ void AboutSigninInternals::OnListAccountsComplete(
// Update the observers that the cookie's accounts are updated.
FOR_EACH_OBSERVER(AboutSigninInternals::Observer,
signin_observers_,
- OnCookieAccountsFetched(signin_status.Pass()));
+ OnCookieAccountsFetched(signin_status));
}
AboutSigninInternals::TokenInfo::TokenInfo(

Powered by Google App Engine
This is Rietveld 408576698