Handle multiple signin_internal_uis by using a linked_ptr

components/signin/core/browser/about_signin_internals.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/signin/core/browser/about_signin_internals.h"
 
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/hash.h"
 #include "base/i18n/time_formatting.h"
@@ skipping 205 matching lines @@
 void AboutSigninInternals::Shutdown() {
   signin_manager_->RemoveSigninDiagnosticsObserver(this);
   token_service_->RemoveDiagnosticsObserver(this);
   cookie_changed_subscription_.reset();
 }
 
 void AboutSigninInternals::NotifyObservers() {
   FOR_EACH_OBSERVER(AboutSigninInternals::Observer,
                     signin_observers_,
                     OnSigninStateChanged(
                         signin_status_.ToValue(client_->GetProductVersion())));

[Roger Tawa OOO till Jul 10th, 2014/09/25 01:14:05]

Above line 223 do:

   scoped_ptr<base::Dictionary> dict(
       signin_status_.ToValue(client_->GetProductVersion()));

the pass dict.get() at line 226.

[Mike Lerman, 2014/09/25 17:28:34]

Done.

 }
 
 scoped_ptr<base::DictionaryValue> AboutSigninInternals::GetSigninStatus() {
   return signin_status_.ToValue(client_->GetProductVersion()).Pass();
 }
 
 void AboutSigninInternals::OnAccessTokenRequested(
     const std::string& account_id,
     const std::string& consumer_id,
     const OAuth2TokenService::ScopeSet& scopes) {
@@ skipping 80 matching lines @@
 }
 
 void AboutSigninInternals::OnListAccountsFailure(
     const GoogleServiceAuthError& error) {
   gaia_fetcher_.reset();
   VLOG(1) << "AboutSigninInternals::OnListAccountsFailure:" << error.ToString();
 }
 
 void AboutSigninInternals::OnListAccountsComplete(
     std::vector<std::pair<std::string, bool> >& gaia_accounts) {
-  scoped_ptr<base::DictionaryValue> signin_status(new base::DictionaryValue());
+  linked_ptr<base::DictionaryValue> signin_status(new base::DictionaryValue());

[Roger Tawa OOO till Jul 10th, 2014/09/25 01:14:05]

Could declare this on the stack:

   base::Dictionary signin_status;

then pass |&signin_status| at line 343 below.

[Mike Lerman, 2014/09/25 17:28:34]

Done.

   base::ListValue* cookie_info = new base::ListValue();
   signin_status->Set("cookie_info", cookie_info);
 
   for (size_t i = 0; i < gaia_accounts.size(); ++i) {
     AddCookieEntry(cookie_info,
                    gaia_accounts[i].first,
                    gaia_accounts[i].second ? "Valid" : "Invalid");
   }
 
   if (gaia_accounts.size() == 0)
     AddCookieEntry(cookie_info, "No Accounts Present.", "");
 
   // Update the observers that the cookie's accounts are updated.
   FOR_EACH_OBSERVER(AboutSigninInternals::Observer,
                     signin_observers_,
-                    OnCookieAccountsFetched(signin_status.Pass()));
+                    OnCookieAccountsFetched(signin_status));
 }
 
 AboutSigninInternals::TokenInfo::TokenInfo(
     const std::string& consumer_id,
     const OAuth2TokenService::ScopeSet& scopes)
     : consumer_id(consumer_id),
       scopes(scopes),
       request_time(base::Time::Now()),
       error(GoogleServiceAuthError::AuthErrorNone()),
       removed_(false) {}
@@ skipping 127 matching lines @@
     std::sort(it->second.begin(), it->second.end(), TokenInfo::LessThan);
     const std::vector<TokenInfo*>& tokens = it->second;
     for (size_t i = 0; i < tokens.size(); ++i) {
       base::DictionaryValue* token_info = tokens[i]->ToValue();
       token_details->Append(token_info);
     }
   }
 
   return signin_status.Pass();
 }