chrome/browser/ui/webui/signin_internals_ui.h - Issue 602773002: Handle multiple signin_internal_uis by using a linked_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin_internals_ui.h

Issue 602773002: Handle multiple signin_internal_uis by using a linked_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/signin_internals_ui.h

diff --git a/chrome/browser/ui/webui/signin_internals_ui.h b/chrome/browser/ui/webui/signin_internals_ui.h

index 84cdeec2727d1c8badbb8f2e1e47483388f1ad4a..22ada4ca9efbdbfe9ee27c627102b5991c5373c2 100644

--- a/chrome/browser/ui/webui/signin_internals_ui.h

+++ b/chrome/browser/ui/webui/signin_internals_ui.h

@@ -31,7 +31,7 @@ class SignInInternalsUI : public content::WebUIController,

// Notification that the cookie accounts are ready to be displayed.

virtual void OnCookieAccountsFetched(

- scoped_ptr<base::DictionaryValue> info) OVERRIDE;

+ linked_ptr<base::DictionaryValue> info) OVERRIDE;

Roger Tawa OOO till Jul 10th 2014/09/25 01:14:05 Would be better to change this function and the on

Mike Lerman 2014/09/25 17:28:34 Done.

private:

DISALLOW_COPY_AND_ASSIGN(SignInInternalsUI);

« no previous file with comments | « no previous file | chrome/browser/ui/webui/signin_internals_ui.cc » ('j') | components/signin/core/browser/about_signin_internals.cc » ('J')