Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: Source/core/editing/VisiblePosition.cpp

Issue 602423002: Mixing content editable and non-editable in direction RTL (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated as per code review comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/VisiblePosition.cpp
diff --git a/Source/core/editing/VisiblePosition.cpp b/Source/core/editing/VisiblePosition.cpp
index 6f43eafb0198aaad4089e7fbe8c8d828fd1176be..8fce3840cf42975798da3e78aee4467aedc3eab7 100644
--- a/Source/core/editing/VisiblePosition.cpp
+++ b/Source/core/editing/VisiblePosition.cpp
@@ -280,8 +280,7 @@ VisiblePosition VisiblePosition::left(bool stayInEditableContent) const
if (!stayInEditableContent)
return left;
- // FIXME: This may need to do something different from "before".
- return honorEditingBoundaryAtOrBefore(left);
+ return isEnclosingBoxHasLeftToRightDirection(left.deepEquivalent()) ? honorEditingBoundaryAtOrBefore(left) : honorEditingBoundaryAtOrAfter(left);
leviw_travelin_and_unemployed 2014/10/14 23:04:40 Use the old method and do your bool check here...
Habib Virji 2014/10/16 15:55:09 Done.
}
Position VisiblePosition::rightVisuallyDistinctCandidate() const
@@ -448,8 +447,7 @@ VisiblePosition VisiblePosition::right(bool stayInEditableContent) const
if (!stayInEditableContent)
return right;
- // FIXME: This may need to do something different from "after".
- return honorEditingBoundaryAtOrAfter(right);
+ return isEnclosingBoxHasLeftToRightDirection(right.deepEquivalent()) ? honorEditingBoundaryAtOrAfter(right) : honorEditingBoundaryAtOrBefore(right);
}
VisiblePosition VisiblePosition::honorEditingBoundaryAtOrBefore(const VisiblePosition &pos) const

Powered by Google App Engine
This is Rietveld 408576698