Source/core/editing/FrameSelection.cpp - Issue 602423002: Mixing content editable and non-editable in direction RTL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 602423002: Mixing content editable and non-editable in direction RTL (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated as per code review comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/editing/selection/skip-non-editable-rtl-expected.txt ('k') | Source/core/editing/VisiblePosition.cpp » ('j') | Source/core/editing/VisiblePosition.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/FrameSelection.cpp

diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp

index 04c181c5199020ae4c312cf7dcf5466b32ad776a..35afcb8f626c2820e947d2dcb2d7916846f9c1a7 100644

--- a/Source/core/editing/FrameSelection.cpp

+++ b/Source/core/editing/FrameSelection.cpp

@@ -477,7 +477,7 @@ void FrameSelection::updateSelectionIfNeeded(const Position& base, const Positio

TextDirection FrameSelection::directionOfEnclosingBlock()

{

- return blink::directionOfEnclosingBlock(m_selection.extent());

+ return blink::isEnclosingBoxHasLeftToRightDirection(m_selection.extent()) ? LTR : RTL;

}

TextDirection FrameSelection::directionOfSelection()