Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1809)

Issue 602083002: Revert of Removed the ScriptedSpeech content side. (Closed)

Created:
6 years, 2 months ago by Michael van Ouwerkerk
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit), MRV
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Removed the ScriptedSpeech content side. (patchset #2 id:20001 of https://codereview.chromium.org/598923002/) Reason for revert: I'm sorry, the ENABLE_SPEECH_RECOGNITION switch is still used in the Chrome on Android repo. I don't see (on the short term) another way of handling this than not removing that switch. I'm going to revert this change. Original issue's description: > Removed the ScriptedSpeech content side. > > Removal the corresponding changes in blink are applied in the following patch > https://codereview.chromium.org/599863002/ > > BUG=402536 > > Committed: https://crrev.com/6b8dda12a7d842517c5c4ee155cf48951e908a7f > Cr-Commit-Position: refs/heads/master@{#296655} TBR=avi@chromium.org,mohan.reddy@samsung.com NOTREECHECKS=true NOTRY=true BUG=402536 Committed: https://crrev.com/5affd816675a57698f20260c6af0a894d7d4e9c8 Cr-Commit-Position: refs/heads/master@{#296692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/ContentSwitches.java View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael van Ouwerkerk
Created Revert of Removed the ScriptedSpeech content side.
6 years, 2 months ago (2014-09-25 11:33:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602083002/1
6 years, 2 months ago (2014-09-25 11:33:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 02a4902d35e9fb9109c8bea588bf951f4b0d1ecb
6 years, 2 months ago (2014-09-25 11:34:23 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5affd816675a57698f20260c6af0a894d7d4e9c8 Cr-Commit-Position: refs/heads/master@{#296692}
6 years, 2 months ago (2014-09-25 11:35:06 UTC) #4
Avi (use Gerrit)
On 2014/09/25 11:35:06, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
6 years, 2 months ago (2014-09-25 15:32:08 UTC) #5
MRV
6 years, 2 months ago (2014-09-26 02:48:29 UTC) #6
Message was sent while issue was closed.
On 2014/09/25 15:32:08, Avi wrote:
> On 2014/09/25 11:35:06, I haz the power (commit-bot) wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/5affd816675a57698f20260c6af0a894d7d4e9c8
> > Cr-Commit-Position: refs/heads/master@{#296692}
> 
> Please coordinate with the Blink team. Either we do or we don't need this
> switch, and I'd rather get this settled by discussion than reverts.

Dear Mr.avi, thanks for feedback.
I'll definatly co-ordinate with blink team first, while making any changes to
interfaces.

Powered by Google App Engine
This is Rietveld 408576698