Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 599863002: Removed ScriptedSpeech from RuntimeEnabledFeature (Closed)

Created:
6 years, 3 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, mkwst+moarreviews_chromium.org, eseidel
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removed ScriptedSpeech from RuntimeEnabledFeature Removed the ScriptedSpeech and its dependencies in blink side. BUG=402536

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M Source/modules/speech/WindowSpeech.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
MRV
Corresponding chromiumside patch is submitted in the following: https://codereview.chromium.org/598923002/ PTAL
6 years, 3 months ago (2014-09-24 09:02:48 UTC) #2
MRV
On 2014/09/24 09:02:48, MRV wrote: > Corresponding chromiumside patch is submitted in the following: > ...
6 years, 2 months ago (2014-09-25 05:37:45 UTC) #3
Michael van Ouwerkerk
On 2014/09/25 05:37:45, MRV wrote: > On 2014/09/24 09:02:48, MRV wrote: > > Corresponding chromiumside ...
6 years, 2 months ago (2014-09-25 11:31:47 UTC) #4
MRV
6 years, 2 months ago (2014-09-25 11:38:52 UTC) #5 
On 2014/09/25 11:31:47, Michael van Ouwerkerk wrote:
> On 2014/09/25 05:37:45, MRV wrote:
> > On 2014/09/24 09:02:48, MRV wrote:
> > > Corresponding chromiumside patch is submitted in the following:
> > > https://codereview.chromium.org/598923002/
> > > PTAL
> > 
> > @ Mr. abarth, corresponding the chromium side check-in is landed. 
> > https://codereview.chromium.org/598923002/
> > 
> > Please review my patch.
> 
> I'm sorry, the ENABLE_SPEECH_RECOGNITION switch is still used in the Chrome on
> Android repo. I don't see (on the short term) another way of handling this
than
> not removing that switch. Would you mind not making this change? Thanks!

Thanks Mr. Micheal, for explanation.

I going to close this review now.

Powered by Google App Engine
This is Rietveld 408576698