Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: Source/core/dom/shadow/ShadowRoot.cpp

Issue 60113005: Enable chromium_code=1 on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: . Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/shadow/ShadowRoot.cpp
diff --git a/Source/core/dom/shadow/ShadowRoot.cpp b/Source/core/dom/shadow/ShadowRoot.cpp
index 95865b8c5213e66dab9cae028e1176a41d3f392d..1a7f7db5e58db56db36df5204e8e9c075b2312db 100644
--- a/Source/core/dom/shadow/ShadowRoot.cpp
+++ b/Source/core/dom/shadow/ShadowRoot.cpp
@@ -212,7 +212,7 @@ void ShadowRoot::setApplyAuthorStyles(bool value)
if (isOrphan())
return;
- if (m_applyAuthorStyles == value)
+ if (static_cast<bool>(m_applyAuthorStyles) == value)
Nico 2013/11/06 05:03:14 I was about to suggest changin the type of m_apply
Peter Kasting 2013/11/06 07:20:02 Based on searches I did online, it looks like the
return;
m_applyAuthorStyles = value;
@@ -238,7 +238,7 @@ void ShadowRoot::setResetStyleInheritance(bool value)
if (isOrphan())
return;
- if (value == m_resetStyleInheritance)
+ if (value == static_cast<bool>(m_resetStyleInheritance))
Nico 2013/11/06 05:03:14 (same comment)
return;
m_resetStyleInheritance = value;

Powered by Google App Engine
This is Rietveld 408576698