Source/core/rendering/ClipRect.h - Issue 60113005: Enable chromium_code=1 on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/ClipRect.h

Issue 60113005: Enable chromium_code=1 on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: . Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/ClipRect.h

diff --git a/Source/core/rendering/ClipRect.h b/Source/core/rendering/ClipRect.h

index 01feb663bbff74480b87076bef0aac0474f3e83c..603c4a84ceff51b10258b6e6f459554949c24279 100644

--- a/Source/core/rendering/ClipRect.h

+++ b/Source/core/rendering/ClipRect.h

@@ -138,7 +138,7 @@ public:

return m_overflowClipRect == other.overflowClipRect()

&& m_fixedClipRect == other.fixedClipRect()

&& m_posClipRect == other.posClipRect()

- && m_fixed == other.fixed();

+ && static_cast<bool>(m_fixed) == other.fixed();

Nico 2013/11/06 05:03:14 Hm, I'd probably either call functions on both lhs

Peter Kasting 2013/11/06 07:20:02 Yeah, calling accessors on both sides seems nice;

}

ClipRects& operator=(const ClipRects& other)