Enable chromium_code=1 on Windows

Source/core/dom/shadow/ShadowRoot.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Neither the name of Google Inc. nor the names of its
@@ skipping 194 matching lines @@
         if (!shadowRoot->containsShadowElements())
             return false;
     return true;
 }
 
 void ShadowRoot::setApplyAuthorStyles(bool value)
 {
     if (isOrphan())
         return;
 
-    if (m_applyAuthorStyles == value)
+    if (static_cast<bool>(m_applyAuthorStyles) == value)

[Nico, 2013/11/06 05:03:14]

I was about to suggest changin the type of m_applyAuthorStyles instead, but I
guess it's unsigned so that it can be packed into the remainder of
m_numberOfStyles which must stay unsigned.

Can you maybe call applyAuthorStyles() instead? That should return the correct
type.

[Peter Kasting, 2013/11/06 07:20:02]

Based on searches I did online, it looks like the precise behavior here is
implementation-defined, and varies by compilers.  I suppose we could test to see
what the compilers we use do.

Otherwise I'd go with using the accessor functions here, below, and in other
files as well.

         return;
 
     m_applyAuthorStyles = value;
     if (!isActive())
         return;
 
     ASSERT(host());
     ASSERT(host()->shadow());
     if (host()->shadow()->didAffectApplyAuthorStyles())
         host()->setNeedsStyleRecalc();
 
     // Since styles in shadow trees can select shadow hosts, set shadow host's needs-recalc flag true.
     // FIXME: host->setNeedsStyleRecalc() should take care of all elements in its shadow tree.
     // However, when host's recalcStyle is skipped (i.e. host's parent has no renderer),
     // no recalc style is invoked for any elements in its shadow tree.
     // This problem occurs when using getComputedStyle() API.
     // So currently host and shadow root's needsStyleRecalc flags are set to be true.
     setNeedsStyleRecalc();
 }
 
 void ShadowRoot::setResetStyleInheritance(bool value)
 {
     if (isOrphan())
         return;
 
-    if (value == m_resetStyleInheritance)
+    if (value == static_cast<bool>(m_resetStyleInheritance))

[Nico, 2013/11/06 05:03:14]

(same comment)

         return;
 
     m_resetStyleInheritance = value;
     if (!isActive())
         return;
 
     setNeedsStyleRecalc();
 }
 
 void ShadowRoot::attach(const AttachContext& context)
@@ skipping 163 matching lines @@
 
 StyleSheetList* ShadowRoot::styleSheets()
 {
     if (!ensureShadowRootRareData()->styleSheets())
         m_shadowRootRareData->setStyleSheets(StyleSheetList::create(this));
 
     return m_shadowRootRareData->styleSheets();
 }
 
 }