Move string descriptor getters from UsbDeviceHandle to UsbDevice.

device/usb/usb_device_handle.h

Index: device/usb/usb_device_handle.h
diff --git a/device/usb/usb_device_handle.h b/device/usb/usb_device_handle.h
index d0b748445b83c0d15061535944b64a60e31efea7..4c00f693e100b9821a07356fef1070926707fc92 100644
--- a/device/usb/usb_device_handle.h
+++ b/device/usb/usb_device_handle.h
@@ -56,9 +56,7 @@ class UsbDeviceHandle : public base::RefCountedThreadSafe<UsbDeviceHandle> {
   virtual bool SetInterfaceAlternateSetting(int interface_number,
                                             int alternate_setting) = 0;
   virtual bool ResetDevice() = 0;
-  virtual bool GetManufacturer(base::string16* manufacturer) = 0;
-  virtual bool GetProduct(base::string16* product) = 0;
-  virtual bool GetSerial(base::string16* serial) = 0;
+  virtual bool GetStringDescriptor(uint8 string_id, base::string16* string) = 0;

[scheib, 2014/09/25 17:36:04]

Why not an enum for string_id? Oh (after research), because we're exposing the
libusb string id concept. Should we do that on the public interface? For this
refactor, consider if you'll take that on.

Then, add function comment, please, and if still using a uint8 please document
what it is.

[Reilly Grant (use Gerrit), 2014/09/25 17:58:44]

It'll be gone completely from this interface when I refactor this code. All of
this patch is a bit of a hack to get around libusb annoyances.

 
   // Async IO. Can be called on any thread.
   virtual void ControlTransfer(UsbEndpointDirection direction,