Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: device/usb/usb_device_handle_impl.h

Issue 601073002: Move string descriptor getters from UsbDeviceHandle to UsbDevice. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/usb/usb_device_handle_impl.h
diff --git a/device/usb/usb_device_handle_impl.h b/device/usb/usb_device_handle_impl.h
index 11ae94f5c69f1c5cde7ba3a04480e5f8ca2aeeed..effb9bae01944ce1e40eecd9682ea617874d6055 100644
--- a/device/usb/usb_device_handle_impl.h
+++ b/device/usb/usb_device_handle_impl.h
@@ -40,9 +40,9 @@ class UsbDeviceHandleImpl : public UsbDeviceHandle {
virtual bool SetInterfaceAlternateSetting(int interface_number,
int alternate_setting) OVERRIDE;
virtual bool ResetDevice() OVERRIDE;
- virtual bool GetManufacturer(base::string16* manufacturer) OVERRIDE;
- virtual bool GetProduct(base::string16* product) OVERRIDE;
- virtual bool GetSerial(base::string16* serial) OVERRIDE;
+ virtual bool GetStringDescriptor(uint8 string_id,
+ base::string16* string) OVERRIDE;
+
virtual void ControlTransfer(UsbEndpointDirection direction,
TransferRequestType request_type,
TransferRecipient recipient,
@@ -132,7 +132,6 @@ class UsbDeviceHandleImpl : public UsbDeviceHandle {
void CompleteTransfer(PlatformUsbTransferHandle transfer);
bool GetSupportedLanguages();
- bool GetStringDescriptor(uint8 string_id, base::string16* string);
// Informs the object to drop internal references.
void InternalClose();

Powered by Google App Engine
This is Rietveld 408576698