Move string descriptor getters from UsbDeviceHandle to UsbDevice.

device/usb/usb_device_handle.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_USB_USB_DEVICE_HANDLE_H_
 #define DEVICE_USB_USB_DEVICE_HANDLE_H_
 
 #include <map>
 #include <vector>
 
@@ skipping 38 matching lines @@
   // The platform device handle will be closed when UsbDeviceHandle destructs.
   virtual void Close() = 0;
 
   // Device manipulation operations. These methods are blocking and must be
   // called on FILE thread.
   virtual bool ClaimInterface(int interface_number) = 0;
   virtual bool ReleaseInterface(int interface_number) = 0;
   virtual bool SetInterfaceAlternateSetting(int interface_number,
                                             int alternate_setting) = 0;
   virtual bool ResetDevice() = 0;
-  virtual bool GetManufacturer(base::string16* manufacturer) = 0;
-  virtual bool GetProduct(base::string16* product) = 0;
-  virtual bool GetSerial(base::string16* serial) = 0;
+  virtual bool GetStringDescriptor(uint8 string_id, base::string16* string) = 0;

[scheib, 2014/09/25 17:36:04]

Why not an enum for string_id? Oh (after research), because we're exposing the
libusb string id concept. Should we do that on the public interface? For this
refactor, consider if you'll take that on.

Then, add function comment, please, and if still using a uint8 please document
what it is.

[Reilly Grant (use Gerrit), 2014/09/25 17:58:44]

It'll be gone completely from this interface when I refactor this code. All of
this patch is a bit of a hack to get around libusb annoyances.

 
   // Async IO. Can be called on any thread.
   virtual void ControlTransfer(UsbEndpointDirection direction,
                                TransferRequestType request_type,
                                TransferRecipient recipient,
                                uint8 request,
                                uint16 value,
                                uint16 index,
                                net::IOBuffer* buffer,
                                size_t length,
@@ skipping 29 matching lines @@
   UsbDeviceHandle() {};
 
   virtual ~UsbDeviceHandle() {};
 
   DISALLOW_COPY_AND_ASSIGN(UsbDeviceHandle);
 };
 
 }  // namespace device
 
 #endif  // DEVICE_USB_USB_DEVICE_HANDLE_H_