Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 60083014: Add sk_float_rsqrt with SSE + NEON fast paths. (Closed)

Created:
7 years, 1 month ago by mtklein
Modified:
7 years, 1 month ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add sk_float_rsqrt with SSE + NEON fast paths. Current numbers: N4: running bench [640 480] math_fastIsqrt NONRENDERING: cmsecs = 3.12 running bench [640 480] math_slowIsqrt NONRENDERING: cmsecs = 4.82 running bench [640 480] math_sk_float_rsqrt NONRENDERING: cmsecs = 1.99 Desktop: running bench [640 480] math_fastIsqrt NONRENDERING: cmsecs = 0.89 running bench [640 480] math_slowIsqrt NONRENDERING: cmsecs = 0.94 running bench [640 480] math_sk_float_rsqrt NONRENDERING: cmsecs = 0.09 Haven't found any other benches where this is a significant effect yet. BUG= Committed: http://code.google.com/p/skia/source/detail?r=12203

Patch Set 1 #

Patch Set 2 : names #

Patch Set 3 : phone #

Patch Set 4 : note #

Patch Set 5 : names #

Patch Set 6 : uncomment #

Patch Set 7 : reup #

Total comments: 2

Patch Set 8 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -294 lines) Patch
M bench/MathBench.cpp View 1 2 3 4 2 chunks +17 lines, -0 lines 0 comments Download
M include/core/SkFloatingPoint.h View 1 2 3 4 5 6 7 1 chunk +41 lines, -0 lines 0 comments Download
M include/core/SkPoint.h View 1 2 3 4 5 6 7 4 chunks +12 lines, -14 lines 0 comments Download
M src/core/SkPoint.cpp View 1 2 3 4 5 6 7 2 chunks +17 lines, -277 lines 0 comments Download
M tests/PointTest.cpp View 1 2 3 4 5 6 7 2 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
for your early perusal. NEON tomorrow.
7 years, 1 month ago (2013-11-07 22:24:48 UTC) #1
reed1
https://codereview.chromium.org/60083014/diff/150001/include/core/SkFloatingPoint.h File include/core/SkFloatingPoint.h (right): https://codereview.chromium.org/60083014/diff/150001/include/core/SkFloatingPoint.h#newcode106 include/core/SkFloatingPoint.h:106: inline float sk_float_rsqrt(float x) { static ... https://codereview.chromium.org/60083014/diff/150001/src/core/SkPoint.cpp File ...
7 years, 1 month ago (2013-11-07 22:28:44 UTC) #2
mtklein
On 2013/11/07 22:28:44, reed1 wrote: > https://codereview.chromium.org/60083014/diff/150001/include/core/SkFloatingPoint.h > File include/core/SkFloatingPoint.h (right): > > https://codereview.chromium.org/60083014/diff/150001/include/core/SkFloatingPoint.h#newcode106 > ...
7 years, 1 month ago (2013-11-08 16:47:44 UTC) #3
reed1
lgtm
7 years, 1 month ago (2013-11-08 20:02:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/60083014/220001
7 years, 1 month ago (2013-11-08 20:05:44 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-08 20:14:33 UTC) #6
Message was sent while issue was closed.
Change committed as 12203

Powered by Google App Engine
This is Rietveld 408576698