Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 60013005: Remove safe-browsing false-positive tracking. (Closed)

Created:
7 years, 1 month ago by Scott Hess - ex-Googler
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Remove safe-browsing false-positive tracking. This code originally tracked false positives in BloomFilter. PrefixSet doesn't have false positives in the same way, so the number is misleading. BUG=64988 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234695

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -100 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_database.cc View 5 chunks +3 lines, -16 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store.h View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store.cc View 2 chunks +1 line, -43 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file.cc View 3 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_unittest_helper.cc View 10 chunks +0 lines, -15 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Scott Hess - ex-Googler
Was randomly reviewing bugs and realized this one was obsolete at this point.
7 years, 1 month ago (2013-11-05 22:29:43 UTC) #1
mattm
lgtm
7 years, 1 month ago (2013-11-05 22:56:40 UTC) #2
Alexei Svitkine (slow)
histograms.xml lgtm
7 years, 1 month ago (2013-11-05 23:12:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/60013005/1
7 years, 1 month ago (2013-11-06 00:27:11 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, mini_installer_test, ...
7 years, 1 month ago (2013-11-06 02:38:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/60013005/1
7 years, 1 month ago (2013-11-12 20:28:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/60013005/1
7 years, 1 month ago (2013-11-12 23:34:36 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 01:20:05 UTC) #8
Message was sent while issue was closed.
Change committed as 234695

Powered by Google App Engine
This is Rietveld 408576698