Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_store_file.cc

Issue 60013005: Remove safe-browsing false-positive tracking. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_store_file.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_store_file.cc b/chrome/browser/safe_browsing/safe_browsing_store_file.cc
index 628907c0e4215e87bcef333afcb4af18ae523b81..10442c4e439478b14e743a1ca3a7bfa5b2fedd17 100644
--- a/chrome/browser/safe_browsing/safe_browsing_store_file.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_store_file.cc
@@ -476,7 +476,6 @@ bool SafeBrowsingStoreFile::FinishChunk() {
bool SafeBrowsingStoreFile::DoUpdate(
const std::vector<SBAddFullHash>& pending_adds,
- const std::set<SBPrefix>& prefix_misses,
SBAddPrefixes* add_prefixes_result,
std::vector<SBAddFullHash>* add_full_hashes_result) {
DCHECK(file_.get() || empty_);
@@ -600,10 +599,6 @@ bool SafeBrowsingStoreFile::DoUpdate(
add_full_hashes.insert(add_full_hashes.end(),
pending_adds.begin(), pending_adds.end());
- // Check how often a prefix was checked which wasn't in the
- // database.
- SBCheckPrefixMisses(add_prefixes, prefix_misses);
-
// Knock the subs from the adds and process deleted chunks.
SBProcessSubs(&add_prefixes, &sub_prefixes,
&add_full_hashes, &sub_full_hashes,
@@ -675,16 +670,12 @@ bool SafeBrowsingStoreFile::DoUpdate(
bool SafeBrowsingStoreFile::FinishUpdate(
const std::vector<SBAddFullHash>& pending_adds,
- const std::set<SBPrefix>& prefix_misses,
SBAddPrefixes* add_prefixes_result,
std::vector<SBAddFullHash>* add_full_hashes_result) {
DCHECK(add_prefixes_result);
DCHECK(add_full_hashes_result);
- bool ret = DoUpdate(pending_adds, prefix_misses,
- add_prefixes_result, add_full_hashes_result);
-
- if (!ret) {
+ if (!DoUpdate(pending_adds, add_prefixes_result, add_full_hashes_result)) {
CancelUpdate();
return false;
}

Powered by Google App Engine
This is Rietveld 408576698