Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6452)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_store.h

Issue 60013005: Remove safe-browsing false-positive tracking. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_store.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_store.h b/chrome/browser/safe_browsing/safe_browsing_store.h
index 917e3574feaf00ad002b0f1774e1b557102f7980..4ea8f8f950adc3c52b397f458749021739bf0274 100644
--- a/chrome/browser/safe_browsing/safe_browsing_store.h
+++ b/chrome/browser/safe_browsing/safe_browsing_store.h
@@ -146,11 +146,6 @@ void SBProcessSubs(SBAddPrefixes* add_prefixes,
const base::hash_set<int32>& add_chunks_deleted,
const base::hash_set<int32>& sub_chunks_deleted);
-// Records a histogram of the number of items in |prefix_misses| which
-// are not in |add_prefixes|.
-void SBCheckPrefixMisses(const SBAddPrefixes& add_prefixes,
- const std::set<SBPrefix>& prefix_misses);
-
// TODO(shess): This uses int32 rather than int because it's writing
// specifically-sized items to files. SBPrefix should likewise be
// explicitly sized.
@@ -234,12 +229,9 @@ class SafeBrowsingStore {
// |pending_adds| is the set of full hashes which have been received
// since the previous update, and is provided as a convenience
// (could be written via WriteAddHash(), but that would flush the
- // chunk to disk). |prefix_misses| is the set of prefixes where the
- // |GetHash()| request returned no full hashes, used for diagnostic
- // purposes.
+ // chunk to disk).
virtual bool FinishUpdate(
const std::vector<SBAddFullHash>& pending_adds,
- const std::set<SBPrefix>& prefix_misses,
SBAddPrefixes* add_prefixes_result,
std::vector<SBAddFullHash>* add_full_hashes_result) = 0;
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_database.cc ('k') | chrome/browser/safe_browsing/safe_browsing_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698