Draw a focus ring around native views when ChromeVox is running.

Draw a focus ring around native views when ChromeVox is running.

Previously a focus ring was only drawn around web elements; this uses a
new API to draw the focus ring around native views, too, by adding a new
field to the existing private accessibility API with the bounding rect of
the focused view.

BUG=314889
Committed: https://crrev.com/c9c86ac16a105db1c457ebd01a4d26342b88dee2
Cr-Commit-Position: refs/heads/master@{#296970}

[dmazzoni, 2014-09-24 18:44:47]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[David Tseng, 2014-09-25 16:43:27]

https://codereview.chromium.org/600063002/diff/1/chrome/browser/resources/chr...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js
(right):

https://codereview.chromium.org/600063002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js:167:
chrome.accessibilityPrivate.setFocusRing([]);
I'm not really sure what this means? Does this clear the focus ring?

https://codereview.chromium.org/600063002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js:409:
chrome.accessibilityPrivate.setFocusRing([ctl.bounds]);
What happens on non-Chrome OS?

https://codereview.chromium.org/600063002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox/chromevox/background/externs.js
(right):

https://codereview.chromium.org/600063002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/background/externs.js:56:
* @param {Array.<{left: number, top: number, width: number, height: number}>}
!Array?

[dmazzoni, 2014-09-25 18:43:45]

https://codereview.chromium.org/600063002/diff/1/chrome/browser/resources/chr...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js
(right):

https://codereview.chromium.org/600063002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js:167:
chrome.accessibilityPrivate.setFocusRing([]);
On 2014/09/25 16:43:27, David Tseng wrote:
> I'm not really sure what this means? Does this clear the focus ring?

Yes. The argument to setFocusRing is an unordered list of rectangles you want to
outline; it properly handles a selection that spans multiple elements or a text
range. If you pass it the empty list it outlines nothing.

Added a comment.

https://codereview.chromium.org/600063002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js:409:
chrome.accessibilityPrivate.setFocusRing([ctl.bounds]);
On 2014/09/25 16:43:26, David Tseng wrote:
> What happens on non-Chrome OS?

Good catch, added a check for Chrome OS.

[dmazzoni, 2014-09-25 18:49:00]

dmazzoni@chromium.org changed reviewers:
+ rockot@chromium.org

[dmazzoni, 2014-09-25 18:49:01]

+rockot for chrome/common/extensions/api

[Ken Rockot(use gerrit already), 2014-09-26 15:22:49]

Apologies for the delay, API LGTM

[dmazzoni, 2014-09-26 15:35:00]

No apology needed during perf week, thanks for the review!

[David Tseng, 2014-09-26 16:49:38]

lgtm

[dmazzoni, 2014-09-26 17:18:49]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-09-26 17:19:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/600063002/20001

[commit-bot: I haz the power, 2014-09-26 17:32:28]

Committed patchset #2 (id:20001) as 2030818a125e3016e075947ba6c8d598e4ed981a

[commit-bot: I haz the power, 2014-09-26 17:33:00]

Patchset 2 (id:??) landed as
https://crrev.com/c9c86ac16a105db1c457ebd01a4d26342b88dee2
Cr-Commit-Position: refs/heads/master@{#296970}