chrome/browser/accessibility/accessibility_extension_api.cc - Issue 600063002: Draw a focus ring around native views when ChromeVox is running.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/accessibility/accessibility_extension_api.cc

Issue 600063002: Draw a focus ring around native views when ChromeVox is running. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add check for Chrome OS Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/accessibility/accessibility_events.cc ('k') | chrome/browser/accessibility/accessibility_extension_api_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/accessibility/accessibility_extension_api.cc

diff --git a/chrome/browser/accessibility/accessibility_extension_api.cc b/chrome/browser/accessibility/accessibility_extension_api.cc

index 63957ae5049cd631c65a57a630c6e295f667431e..8cbc4d3bceb48aa1d4d084f915bddddd68d1f8f7 100644

--- a/chrome/browser/accessibility/accessibility_extension_api.cc

+++ b/chrome/browser/accessibility/accessibility_extension_api.cc

@@ -323,10 +323,10 @@ bool AccessibilityPrivateSetFocusRingFunction::RunSync() {

base::DictionaryValue* rect_value = NULL;

EXTENSION_FUNCTION_VALIDATE(rect_values->GetDictionary(i, &rect_value));

int left, top, width, height;

- EXTENSION_FUNCTION_VALIDATE(rect_value->GetInteger("left", &left));

- EXTENSION_FUNCTION_VALIDATE(rect_value->GetInteger("top", &top));

- EXTENSION_FUNCTION_VALIDATE(rect_value->GetInteger("width", &width));

- EXTENSION_FUNCTION_VALIDATE(rect_value->GetInteger("height", &height));

+ EXTENSION_FUNCTION_VALIDATE(rect_value->GetInteger(keys::kLeft, &left));

+ EXTENSION_FUNCTION_VALIDATE(rect_value->GetInteger(keys::kTop, &top));

+ EXTENSION_FUNCTION_VALIDATE(rect_value->GetInteger(keys::kWidth, &width));

+ EXTENSION_FUNCTION_VALIDATE(rect_value->GetInteger(keys::kHeight, &height));

rects.push_back(gfx::Rect(left, top, width, height));

}