Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6273)

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js

Issue 600063002: Draw a focus ring around native views when ChromeVox is running. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add check for Chrome OS Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js
diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js b/chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js
index c015b6d9be3c57926467dd1b1a01969ca3119b6c..fd1bdb51ee83ae06d3206b93f0fa23cd3bdf782e 100644
--- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js
+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js
@@ -162,6 +162,12 @@ cvox.AccessibilityApiHandler.prototype.setWebContext = function() {
this.lastContext = '--internal-web--';
this.editableTextHandler = null;
this.editableTextName = '';
+
+ if (chrome.accessibilityPrivate.setFocusRing &&
+ cvox.ChromeVox.isChromeOS) {
+ // Clear the focus ring.
+ chrome.accessibilityPrivate.setFocusRing([]);
+ }
};
/**
@@ -401,6 +407,12 @@ cvox.AccessibilityApiHandler.prototype.onControlFocused = function(ctl) {
return;
}
+ if (ctl.bounds &&
+ chrome.accessibilityPrivate.setFocusRing &&
+ cvox.ChromeVox.isChromeOS) {
+ chrome.accessibilityPrivate.setFocusRing([ctl.bounds]);
+ }
+
// Call this first because it may clear this.editableTextHandler.
var description = this.describe(ctl, false);

Powered by Google App Engine
This is Rietveld 408576698