Make gn check //mojo/public/* pass

Make gn check //mojo/public/* pass

This adds a few header-only targets which are useful for explicitly
tracking our dependencies and propagating configs.

R=viettrungluu@chromium.org

Committed: https://crrev.com/2225a856d788dcdd39c2f8eb70c50f7018b079cb
Cr-Commit-Position: refs/heads/master@{#296900}

[viettrungluu, 2014-09-25 00:36:22]

https://codereview.chromium.org/599283003/diff/1/mojo/public/c/system/BUILD.gn
File mojo/public/c/system/BUILD.gn (right):

https://codereview.chromium.org/599283003/diff/1/mojo/public/c/system/BUILD.g...
mojo/public/c/system/BUILD.gn:51: source_set("system") {
Maybe it'd be more consistent (with the pattern for the other directories) to
keep "headers" as "system", and call this something else?

(E.g., a NaCl app would want to depend on the headers, but not this.)

https://codereview.chromium.org/599283003/diff/1/mojo/public/cpp/bindings/tes...
File mojo/public/cpp/bindings/tests/BUILD.gn (right):

https://codereview.chromium.org/599283003/diff/1/mojo/public/cpp/bindings/tes...
mojo/public/cpp/bindings/tests/BUILD.gn:29: "//mojo/public/cpp/system",
I wonder if cpp/bindings should have cpp/system in its public_deps,
and if cpp/system should have c/system in its public_deps.

https://codereview.chromium.org/599283003/diff/1/mojo/public/cpp/utility/test...
File mojo/public/cpp/utility/tests/BUILD.gn (right):

https://codereview.chromium.org/599283003/diff/1/mojo/public/cpp/utility/test...
mojo/public/cpp/utility/tests/BUILD.gn:11: "//mojo/public/cpp/system",
nit: alphabetical-order-ish?

[jamesr, 2014-09-25 07:59:23]

OK, I'll make //mojo/public/c/system be the headers target and have
//mojo/public/c/system:thunks be the private thunk target (or maybe put that in
some other location), and make //mojo/public/cpp/{environment,system} list
//mojo/public/c/\1 as a public_deps so you can declare a dependency on only the
cpp target and use the c headers.  Those both sound pretty reasonable.  gn check
seems fucked up on mac though so I'll do this tomorrow.

[jamesr, 2014-09-26 00:23:15]

OK, PTAL

[viettrungluu, 2014-09-26 00:34:41]

lgtm w/nits

https://codereview.chromium.org/599283003/diff/20001/mojo/public/c/gles2/BUIL...
File mojo/public/c/gles2/BUILD.gn (right):

https://codereview.chromium.org/599283003/diff/20001/mojo/public/c/gles2/BUIL...
mojo/public/c/gles2/BUILD.gn:22: 
Noooooooooooooooooooooooo, extra EOF newline.

https://codereview.chromium.org/599283003/diff/20001/mojo/public/cpp/bindings...
File mojo/public/cpp/bindings/BUILD.gn (right):

https://codereview.chromium.org/599283003/diff/20001/mojo/public/cpp/bindings...
mojo/public/cpp/bindings/BUILD.gn:67: 
" x2

https://codereview.chromium.org/599283003/diff/20001/mojo/public/cpp/utility/...
File mojo/public/cpp/utility/tests/BUILD.gn (right):

https://codereview.chromium.org/599283003/diff/20001/mojo/public/cpp/utility/...
mojo/public/cpp/utility/tests/BUILD.gn:11: "//mojo/public/cpp/system",
nit: alphabetical order?

[jamesr, 2014-09-26 04:46:50]

https://codereview.chromium.org/599283003/diff/20001/mojo/public/c/gles2/BUIL...
File mojo/public/c/gles2/BUILD.gn (right):

https://codereview.chromium.org/599283003/diff/20001/mojo/public/c/gles2/BUIL...
mojo/public/c/gles2/BUILD.gn:22: 
On 2014/09/26 00:34:41, viettrungluu wrote:
> Noooooooooooooooooooooooo, extra EOF newline.

FFFFFUUUUUUU

https://codereview.chromium.org/599283003/diff/20001/mojo/public/cpp/utility/...
File mojo/public/cpp/utility/tests/BUILD.gn (right):

https://codereview.chromium.org/599283003/diff/20001/mojo/public/cpp/utility/...
mojo/public/cpp/utility/tests/BUILD.gn:11: "//mojo/public/cpp/system",
On 2014/09/26 00:34:41, viettrungluu wrote:
> nit: alphabetical order?

dammit i've sorted this section like 5 times in git branches that i've tossed

[jamesr, 2014-09-26 04:48:26]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-09-26 04:49:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/599283003/40001

[commit-bot: I haz the power, 2014-09-26 04:52:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-26 04:52:24]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/61065)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jamesr, 2014-09-26 05:54:11]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-09-26 05:54:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/599283003/60001

[commit-bot: I haz the power, 2014-09-26 06:53:05]

Committed patchset #4 (id:60001) as 84175f79473271dbbeca42184cf30c5c7efe2e9f

[commit-bot: I haz the power, 2014-09-26 06:53:46]

Patchset 4 (id:??) landed as
https://crrev.com/2225a856d788dcdd39c2f8eb70c50f7018b079cb
Cr-Commit-Position: refs/heads/master@{#296900}