Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1622)

Unified Diff: mojo/public/cpp/bindings/BUILD.gn

Issue 599283003: Make gn check //mojo/public/* pass (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/application/BUILD.gn ('k') | mojo/public/cpp/bindings/tests/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/BUILD.gn
diff --git a/mojo/public/cpp/bindings/BUILD.gn b/mojo/public/cpp/bindings/BUILD.gn
index bba3519b5550079c13fc1370c9aeb75422b75a94..dad10d836d5a618e62edc6da6bfa4c28f85acb7e 100644
--- a/mojo/public/cpp/bindings/BUILD.gn
+++ b/mojo/public/cpp/bindings/BUILD.gn
@@ -5,7 +5,6 @@
source_set("bindings") {
sources = [
"array.h",
- "callback.h",
"error_handler.h",
"interface_ptr.h",
"message.h",
@@ -23,7 +22,6 @@ source_set("bindings") {
"lib/bounds_checker.cc",
"lib/bounds_checker.h",
"lib/buffer.h",
- "lib/callback_internal.h",
"lib/connector.cc",
"lib/connector.h",
"lib/filter_chain.cc",
@@ -42,12 +40,27 @@ source_set("bindings") {
"lib/no_interface.cc",
"lib/router.cc",
"lib/router.h",
- "lib/shared_data.h",
- "lib/shared_ptr.h",
"lib/string_serialization.cc",
"lib/string_serialization.h",
- "lib/template_util.h",
"lib/validation_errors.cc",
"lib/validation_errors.h",
]
+
+ deps = [
+ ":callback",
+ "//mojo/public/cpp/environment",
+ "//mojo/public/cpp/system",
+ ]
+}
+
+source_set("callback") {
+ sources = [
+ "callback.h",
+ "lib/callback_internal.h",
+ "lib/template_util.h",
+ "lib/shared_data.h",
+ "lib/shared_ptr.h",
+ ]
+
+ deps = [ "//mojo/public/cpp/system" ]
}
« no previous file with comments | « mojo/public/cpp/application/BUILD.gn ('k') | mojo/public/cpp/bindings/tests/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698